We love Edinburgh, having visited the city many times over the years. This was the second time we've used the caravan club site. Site is well maintained, with friendly wardens. Toilet blocks could perhaps do with an upgrade in the near future, but they were clean. We loved the beach nearby, just a short walk from the site, with a great cafe too. As well as the city, we visited Queensferry with its magnificent views of the forth bridge. Some others have mentioned the noise from aircraft on approach to Edinburgh Airport. I guess it can be intrusive if you're not used to it, but we live on the approach to Liverpool Airport which is similarly busy, and the noise is just something your brain blocks out after a while. I wouldn't let this put you off, as there's so much to see and do in the area if you're merely using the site as a base.